How does this hack work? Does this matter on non-NT OS's? Could we make tests to ensure this continues to work?

How does this hack work? Does this matter on non-NT OS's?

writing in progress #569 (comment)

Could we make tests to ensure this continues to work?

I think the tests is already covered it.

If this patch is not applied, or not working, the tests would fail with many errors.

• the When http-server is listening on 8080 when requesting / test would report Cannot read property 'statusCode' of undefined, as well as the tests regards to compression
• the When http-server is listening on 8080 and options include custom set http-headers test would report Cannot read property 'headers' of undefined
• the When http-server is listening on 8080 when robots options is activated test would report Error: Invalid URI "http:///". This can be caused by a crappy redirection. , straight forward and pointful
  It is the same error that ERR_INVALID_REDIRECT when running http-server #525 reported.

If this patch is applied, no error reported.

By the way, the test system can't work on Node 12 unless I upgrade the vows package from 0.7.0 to the latest version (0.8.3) . (but with vows 0.8.3, the servers won't stop automatically after testing)

writing in progress

Do you have an update? This looks to be hacking into path itself, is that right?

yes, path.normalize

On Linux (or other Unix-like operating systems), path.normalize("/path//to/file") returns "/path/to/file"
But on Windows, path.normalize("/path//to/file") returns "\path\to\file", it is not a valid path component in URL. (It should be separated by /)

This patch forces the path.normalize function to act like it does on *nix, in this specific call stack.

This doesn't matter on non-NT OS's.

Well really this doesn't look too bad, even if super hacky. Still runs for me on Mac, and tests pass. Well tests fail on Node 12 but I think that's a separate problem. I don't have access to a Windows machine to try this out for sure on there, though.

The problem on Node 12 is related to the vows test framework.
When I upgrade vows to the latest version (0.8.3), it is solved.

Oh duh you said that was an issue! When I upgrade to vows 0.8.3, however, vows seems to hang after all the tests pass, before reporting success. Are you getting the same?

@Xmader could you merge master back into this pr? Tests should pass now!

@Xmader could you merge master back into this pr? Tests should pass now!

no problem